This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Increase the size of the decoder buffer to 1meg. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current default is far too small, it's breaking on a node I have that is only 66015 bytes.
vmx
reviewed
Jul 3, 2018
| @@ -30,7 +30,8 @@ const decoder = new cbor.Decoder({ | |||
| val = val.slice(1) | |||
| return {'/': val} | |||
| } | |||
| } | |||
| }, | |||
| size: 1e+6 /* one megabyte */ | |||
There was a problem hiding this comment.
Looking at the implementation, it tries to use power of two. So it make make sense to write is as size: 1024 * 1024 * 1024 (which I find easier to read, but that's a matter of taste).
|
@mikeal I guess you still want this in? |
|
@vmx the default should definitely be larger, but it's not clear to me how much larger. Because of the way CBOR is implemented it requires a static allocation of memory of double the max node size so there will be tradeoffs on increasing it as well. |
|
Should we make the default to a value that Bitswap can still transfer, hence 4MB (see #52 for more discussions on that topic). |
rvagg
added a commit
that referenced
this pull request
Mar 22, 2019
* Introduce some sanity / safety checking to configureDecoder() * Attempting to decode a block larger than the decoder can handle will result in growing the decoder heap Fixes: #73
rvagg
added a commit
that referenced
this pull request
Apr 1, 2019
* Introduce some sanity / safety checking to configureDecoder() * Attempting to decode a block larger than the decoder can handle will result in growing the decoder heap Fixes: #73
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default is far too small, it's breaking on a node I have that is only 66015 bytes.