-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change could be merged without the package.json changes on borc
und aegir
.
Are you missing to remove async
from package.json?
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
- Coverage 92.85% 92.8% -0.06%
=========================================
Files 3 3
Lines 126 125 -1
=========================================
- Hits 117 116 -1
Misses 9 9
Continue to review full report at Codecov.
|
removed async |
@hugomrdias The updates from borc and aegir can then come through either implicit updates (likely for borc) or explicit upgrades (likely for aegir). So you wouldn't need to change this commit again. Also those dependency updates are semi-automatic as Greenkeeper is enabled on this repo. |
its easier for me to have it like this so i dont forget anything and follow a path until a arrive at http-client and ipfs |
@vmx this is ready to merge/release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But it needs a manual rebase, can you please do that @hugomrdias?
@vmx this PR is synced with master |
@hugomrdias GitHub tells me "This branch cannot be rebased due to conflicts". |
This PR reduces the bundle size (OKR work)
53.27KB > 48.66KB -8.64%
Needs