Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

fix: reduce bundle size #87

Merged
merged 3 commits into from
Jan 8, 2019
Merged

fix: reduce bundle size #87

merged 3 commits into from
Jan 8, 2019

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Dec 14, 2018

This PR reduces the bundle size (OKR work)

53.27KB > 48.66KB -8.64%

Needs

@hugomrdias hugomrdias requested a review from vmx December 14, 2018 00:18
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change could be merged without the package.json changes on borc und aegir.

Are you missing to remove async from package.json?

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #87 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #87      +/-   ##
=========================================
- Coverage   92.85%   92.8%   -0.06%     
=========================================
  Files           3       3              
  Lines         126     125       -1     
=========================================
- Hits          117     116       -1     
  Misses          9       9
Impacted Files Coverage Δ
src/util.js 98.38% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c33d9...cab1107. Read the comment docs.

@ghost ghost assigned hugomrdias Dec 14, 2018
@ghost ghost added the status/in-progress In progress label Dec 14, 2018
@hugomrdias
Copy link
Member Author

removed async
it needs to depend on those that borc and aegir make it smaller
can you review the aegir PR ?

@vmx
Copy link
Member

vmx commented Dec 14, 2018

@hugomrdias The updates from borc and aegir can then come through either implicit updates (likely for borc) or explicit upgrades (likely for aegir). So you wouldn't need to change this commit again.

Also those dependency updates are semi-automatic as Greenkeeper is enabled on this repo.

@hugomrdias
Copy link
Member Author

its easier for me to have it like this so i dont forget anything and follow a path until a arrive at http-client and ipfs

@hugomrdias
Copy link
Member Author

@vmx this is ready to merge/release

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But it needs a manual rebase, can you please do that @hugomrdias?

@hugomrdias
Copy link
Member Author

@vmx this PR is synced with master

@vmx
Copy link
Member

vmx commented Jan 8, 2019

@hugomrdias GitHub tells me "This branch cannot be rebased due to conflicts".

@vmx vmx merged commit ab637f3 into ipld:master Jan 8, 2019
@ghost ghost removed the status/in-progress In progress label Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants