This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Make cbor Decoder configurable #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this land. I have something very similar in |
mikeal
approved these changes
Feb 12, 2019
|
Thanks a lot for your contribution, that's a great PR. I'll change the commit message when merging as we are following a certain format, so that the changelog can be auto-generated. For me see https://github.com/ipfs/community/blob/250bb162def759abca469442d72182202ab68380/CONTRIBUTING_JS.md#commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow the underlying
cbor.Decoderto be configured with additional options, namely the size parameter.Currently we are using this library to explore an ipld dag - in some cases, errors are raised due to decoding large objects. By allowing the user to configure the size here, they can determine what the size limit for their application should be.