You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Currently if you pass in a Zcash block that includes transactions, it will only use the header part to calculate the CID. This is wrong.
The correct behaviour (to match the Go IPLD Zcash implementation is to distinguish between zcash-block (multicodec 0xc0), which is the header only and a zcash-tx (multicodec 0xc1).
So building the CID of a zcash-block would then be (as expected by IPLD) to hash the full data, which will then be correct as it only contains the header.
The text was updated successfully, but these errors were encountered:
Currently if you pass in a Zcash block that includes transactions, it will only use the header part to calculate the CID. This is wrong.
The correct behaviour (to match the Go IPLD Zcash implementation is to distinguish between
zcash-block
(multicodec 0xc0), which is the header only and azcash-tx
(multicodec 0xc1).So building the CID of a
zcash-block
would then be (as expected by IPLD) to hash the full data, which will then be correct as it only contains the header.The text was updated successfully, but these errors were encountered: