Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

ipld resolver serializes data more time then nessicary #63

Closed
wanderer opened this issue Oct 29, 2016 · 6 comments
Closed

ipld resolver serializes data more time then nessicary #63

wanderer opened this issue Oct 29, 2016 · 6 comments
Assignees
@vmx
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@wanderer
Copy link
Member

It first serialization the data to create the CID then once again to store the data.
@wanderer
Copy link
Member Author

for now im getting around this by directly interacting with the blockservice

@daviddias daviddias added the status/ready Ready to be worked label Dec 5, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog kind/bug A bug in existing code (including security flaws) and removed js-ipfs-backlog status/ready Ready to be worked labels Jan 29, 2017
@daviddias daviddias added status/ready Ready to be worked P0 Critical: Tackled by core team ASAP and removed status/deferred Conscious decision to pause or backlog status/ready Ready to be worked labels Oct 17, 2017
@daviddias daviddias added status/in-progress In progress and removed status/ready Ready to be worked labels Dec 30, 2017
@daviddias daviddias self-assigned this Dec 30, 2017
@daviddias daviddias added status/ready Ready to be worked and removed status/in-progress In progress labels Jan 25, 2018
@daviddias daviddias removed their assignment Jan 25, 2018
@daviddias daviddias added help wanted Seeking public contribution on this issue exp/expert Having worked on the specific codebase is important labels Jan 25, 2018
@daviddias
Copy link
Member

@vmx getting this on your radar :)

@daviddias daviddias added status/in-progress In progress and removed status/ready Ready to be worked labels Apr 10, 2018
@vmx vmx added status/ready Ready to be worked and removed status/in-progress In progress labels Apr 11, 2018
@richardschneider
Copy link
Contributor

ipld/interface-ipld-format#32 should resolve this issue.

Can we close this?

@vmx
Copy link
Member

vmx commented Jun 24, 2018

Can be closed once ipld/interface-ipld-format#32 is closed. Until then it's an open issue.

@daviddias
Copy link
Member

@vmx if this one is P0, then ipld/interface-ipld-format#32 should be as well

@vmx vmx added the P2 Medium: Good to have, but can wait until someone steps up label Nov 14, 2018
@vmx vmx removed the P0 Critical: Tackled by core team ASAP label Nov 14, 2018
@vmx
Copy link
Member

vmx commented May 8, 2019

cid() is now taking the serialized version of the data, hence it is fixed.

@vmx vmx closed this as completed May 8, 2019
@ghost ghost removed the status/ready Ready to be worked label May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vmx vmx

Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vmx @wanderer @richardschneider @daviddias