-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement flat dir support #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
requested changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the api now
Gozala
commented
Jul 27, 2022
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements preliminary directory support (no sharding or blocksize checks yet). Also makes few API changes to support this:
File.createImporter
API is gone is removed. Instead one should do following:Implementation had be updated to be based on
WritableStream
interface which seems to be more widely available now. This means you can simply create UnixFS writer fromWritableStream
directly:Directory writer interface is intentionally very limited. You can only add entries that were created by writing a file or a directory in prior. This design choice guarantees that you can't have directories with partially written files which you'd need to somehow ensure get closed before you close the directory or have internals that would await for closures. I feel this is a better design as it makes certain bugs impossible (e.g. never resolving promise because some file was not closed).
In addition I have also added experimental
.fork()
method to directories which allows you to "fork" directory into a multiple divergent copies. This could be utilized for example to encode filesystem patches, but it's pretty rough.