Skip to content

Commit 9cd3435

Browse files
committed
remove unused autoStartClient options
leftover from dask-labextension adaptation, but not implemented
1 parent 7b85044 commit 9cd3435

File tree

2 files changed

+31
-38
lines changed

2 files changed

+31
-38
lines changed

lab/schema/plugin.json

+1-8
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,6 @@
33
"jupyter.lab.setting-icon-label": "IPython Parallel",
44
"title": "IPython Parallel",
55
"description": "Settings for the IPython Parallel plugin.",
6-
"properties": {
7-
"autoStartClient": {
8-
"type": "boolean",
9-
"title": "Auto-Start Client",
10-
"description": "If set to true, every notebook and console will automatically have an IPython Parallel Cluster and Client for the active cluster injected into the kernel under the names 'cluster' and 'rc'",
11-
"default": false
12-
}
13-
},
6+
"properties": {},
147
"type": "object"
158
}

lab/src/index.ts

+30-30
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ async function activate(
227227

228228
const onSettingsChanged = () => {
229229
// Determine whether to use the auto-starting client.
230-
autoStartClient = settings.get("autoStartClient").composite as boolean;
230+
// autoStartClient = settings.get("autoStartClient").composite as boolean;
231231
updateTrackers();
232232
};
233233
onSettingsChanged();
@@ -309,35 +309,35 @@ async function activate(
309309
});
310310

311311
// Add a command to toggle the auto-starting client code.
312-
app.commands.addCommand(CommandIDs.toggleAutoStartClient, {
313-
label: "Auto-Start IPython Parallel",
314-
isToggled: () => autoStartClient,
315-
execute: async () => {
316-
const value = !autoStartClient;
317-
const key = "autoStartClient";
318-
return settingRegistry
319-
.set(PLUGIN_ID, key, value)
320-
.catch((reason: Error) => {
321-
console.error(
322-
`Failed to set ${PLUGIN_ID}:${key} - ${reason.message}`
323-
);
324-
});
325-
},
326-
});
327-
328-
// Add some commands to the menu and command palette.
329-
mainMenu.settingsMenu.addGroup([
330-
{ command: CommandIDs.toggleAutoStartClient },
331-
]);
332-
[CommandIDs.newCluster, CommandIDs.toggleAutoStartClient].forEach(
333-
(command) => {
334-
commandPalette.addItem({
335-
category: "IPython Parallel",
336-
command,
337-
args: { isPalette: true },
338-
});
339-
}
340-
);
312+
// app.commands.addCommand(CommandIDs.toggleAutoStartClient, {
313+
// label: "Auto-Start IPython Parallel",
314+
// isToggled: () => autoStartClient,
315+
// execute: async () => {
316+
// const value = !autoStartClient;
317+
// const key = "autoStartClient";
318+
// return settingRegistry
319+
// .set(PLUGIN_ID, key, value)
320+
// .catch((reason: Error) => {
321+
// console.error(
322+
// `Failed to set ${PLUGIN_ID}:${key} - ${reason.message}`
323+
// );
324+
// });
325+
// },
326+
// });
327+
328+
// // Add some commands to the menu and command palette.
329+
// mainMenu.settingsMenu.addGroup([
330+
// { command: CommandIDs.toggleAutoStartClient },
331+
// ]);
332+
// [CommandIDs.newCluster, CommandIDs.toggleAutoStartClient].forEach(
333+
// (command) => {
334+
// commandPalette.addItem({
335+
// category: "IPython Parallel",
336+
// command,
337+
// args: { isPalette: true },
338+
// });
339+
// }
340+
// );
341341

342342
// Add a context menu items.
343343
app.contextMenu.addItem({

0 commit comments

Comments
 (0)