Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explaining contents of model finder output #102

Open
GavinHuttley opened this issue Nov 19, 2024 · 4 comments
Open

explaining contents of model finder output #102

GavinHuttley opened this issue Nov 19, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@GavinHuttley
Copy link
Member

For the model finder, it returns content like

{'F81+F+G4': '-22031.57915 35 3.393933387', 'F81+F+I+G4': '-22019.14569 36 3.498599912', 'GTR+F': '-22701.4875 39 2.863213275', 'GTR+F+G4': '-21155.96905 40 4.183274952', 'GTR+F+I': '-21615.54758 40 3.157092513', 'GTR+F+I+G4': '-21148.84917 41 4.227880748', 'GTR+F+I+R2': '-21174.43313 42 3.977727243', 'GTR+F+I+R3': '-21146.99716 44 4.178975537', 'GTR+F+I+R4': '-21146.7857 46 4.178022765', 'GTR+F+R2': '-21235.65958 41 3.654268215', 'GTR+F+R3': '-21147.07793 43 4.129785335', 'GTR+F+R4': '-21146.62676 45 4.146373298', 'HKY+F+G4': '-21489.74786 36 4.227190047'...

For the first of these, 'F81+F+G4', I need to confirm what the components are. Hopefully the C++ variable names will help '-22031.57915 35 3.393933387' where '-22031.57915' is the log-likelihood, '35' is the degrees of freedom (or number of free parameters) but '3.393933387'?

Other contents in there?

@GavinHuttley
Copy link
Member Author

the third value is tree length

@GavinHuttley
Copy link
Member Author

GavinHuttley commented Dec 3, 2024

write a dataclass ModelResultValue for the values of the dict above which has 3 attributes: lnL: float for the first field,l nfp: int for the second field and tree_length: float for the third.

@KatherineCaley
Copy link

I'll take this on!

@GavinHuttley
Copy link
Member Author

piqtree2/iqtree/_model_finder.py line 58. argument val corresponds to the entries above (-22031.57915 35 3.393933387).

val should be a ModelResultValue instance which has the attributes as defined above.

@thomaskf thomaskf removed their assignment Dec 4, 2024
@rmcar17 rmcar17 added this to the version 0.4 milestone Dec 4, 2024
@rmcar17 rmcar17 added the enhancement New feature or request label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants