-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sendVideo Actually accepts caption field #13
Comments
Hi @jonnywilliamson, That's a great find man 👍 I'm open for the PR. Since the library itself is unofficial and as already stated by their support, they're still in process of improving things. Maybe they missed it and would be made available in their next update or so. Just make sure you properly test several times though. If it's something that temporarily works sometimes and doesn't work always, then it's not really a good idea to add it. I'll drop a message to their support and query about it as well. Still waiting for the response for the #9 issue. Thanks! |
Sorry was out of country with work. Will do this v shortly. |
No problem. Take your time! Thanks. |
Ah i see. They must've added recently. So it's official now, good 👍 Thanks for the contribution @jonnywilliamson. Appreciate it :) |
So i just tested this a few times and it seems like some sort of bug on their end, not the library. Because, I saved the video to the camera roll on iOS and it saved the video just fine and i was able to play it from the Photos app too. However, It didn't play within the Telegram app itself (like you reported). I also tested this on the Telegram Mac client, The video loads fine including the thumbnail, etc. So it could be bug with Telegram iOS app..not sure how its handling the videos within bots API. (I didn't test with Android though). Maybe you should report this to their support and provide this issue link, Let them take a look as well. I'll probably do that as well but they don't seem to be responding at all (Still waiting for those 2 other issues, not even opened/seen my messages). |
Response from support:
|
Its good they got back to you. I had sent a couple of tweets to the @telegram account and pointed to these issues too. Appreciate the feedback! |
Recently Telegram add width and height and duration in its document but videos send with black image preview , I found some videos that sent correctly, I think its about encoding of files. |
The problem still exists! |
Hi,
The official docs show that you can send a caption with
sendMessage
.There is no mention of being able to send a caption with
sendVideo
, however when you actually send a video in a normal client (ie iOS app, desktop etc) you CAN set a caption.I have added the caption variable to the
sendVideo
method in your library and surprise surprise it works perfectly.....but it seems like it was missed when they wrote the documents on the official Telegram site.Would you accept a PR with this added or do you prefer to keep you library in strict adherence to the official docs?
The text was updated successfully, but these errors were encountered: