fix: data export: allow more digits inside the brackets in the phone … #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…number sanitization regex to support more number variants
jekutzsche
reviewed
Nov 22, 2021
There was a problem hiding this comment.
We use different patterns for phone numbers in the BS and in the FE. The data concerned are not directly related, but perhaps we should unify them anyway. However, the BFF does not check phone numbers, but only checks if there are no harmful characters and excludes the + for phone numbers.
…ation before whitelisting to replace tabs, etc. with a single space
jekutzsche
approved these changes
Nov 22, 2021
jekutzsche
pushed a commit
that referenced
this pull request
Nov 29, 2021
# [1.2.0-rc.1](v1.1.1...v1.2.0-rc.1) (2021-11-29) ### Bug Fixes * `+` at the beginning of phone numbers are now preserved during CSV export. So an international phone number now remains complete. ([3464165](3464165)), closes [#443](#443) [#445](#445) * An admin can now change a user's data again. An error occurred ([0fda2b6](0fda2b6)) * Cleans the Docker image of the frontend from artifacts that are only needed for the build. This makes it more secure and greatly reduced in size. ([63051b1](63051b1)), closes [#442](#442) * **data export:** Allow more number variants in the phone number sanitization. ([a181c34](a181c34)), closes [#478](#478) [#479](#479) * Restricts the content of …deployment….zip to the folders and files relevant for deployment. The previously included parent folder is now removed. ([580e551](580e551)), closes [#432](#432) [#433](#433) ### Features * A readable code is now used for the data request to an index case. This consists of four random words and an abbreviation for the department. ([e913f8a](e913f8a)), closes [iris-connect/iris-backlog#245](https://github.com/iris-connect/iris-backlog/issues/245) [#460](#460) * Add event tracking xlsx data export for octoware, refactor and unify the data export functionality ([b442014](b442014)) * **Admin:** Docker is now told the health status of the client backend (BFF) container. Administrators can build monitoring functions on this. ([8d262ac](8d262ac)), closes [#451](#451) * Display checkin app status information in the frontend to inform the user if there are problems with a connected data provider ([c0c21f1](c0c21f1)), closes [iris-connect/iris-backlog#221](https://github.com/iris-connect/iris-backlog/issues/221) [#444](#444) * Provides excel export for event tracking standard format and improves table selection usability. ([5132b0a](5132b0a)), closes [#266](#266) [#476](#476) * Updates EPS from version v0.1.66 to v0.1.68. ([c7afbf5](c7afbf5)) * Uses and requires Java 17 (new long term support version) as baseline. ([558171b](558171b)), closes [#393](#393) * When a user changes his password, the old password is now also expected and checked to ensure it is correct. ([72af5dc](72af5dc)), closes [iris-connect/iris-backlog#250](https://github.com/iris-connect/iris-backlog/issues/250) [#431](#431)
|
🎉 This PR is included in version 1.2.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jekutzsche
pushed a commit
that referenced
this pull request
Dec 14, 2021
# [1.2.0](v1.1.1...v1.2.0) (2021-12-14) ### Bug Fixes * `+` at the beginning of phone numbers are now preserved during CSV export. So an international phone number now remains complete. ([3464165](3464165)), closes [#443](#443) [#445](#445) * An admin can now change a user's data again. An error occurred ([0fda2b6](0fda2b6)) * apply removal of the index-tracking-url to e2e tests and remove the csv data export test for index-tracking as there is no data to export ([0a2a029](0a2a029)) * Avoids readable but not writable announcement.db files for EPS by an update from EPS version v0.1.68 to v0.1.69. ([0ab8c9e](0ab8c9e)) * Cleans the Docker image of the frontend from artifacts that are only needed for the build. This makes it more secure and greatly reduced in size. ([63051b1](63051b1)), closes [#442](#442) * Clearing case_data_request before adding new not-null fields. Not critical, because feature is not in use yet. ([9389239](9389239)), closes [#490](#490) * **data export:** Allow more number variants in the phone number sanitization. ([a181c34](a181c34)), closes [#478](#478) [#479](#479) * extend data export sanitization whitelist to allow a wider range of Latin Letters ([4082e5f](4082e5f)) * Improves timeouts in Client and extends the checks for the status (EPS version) to better determine the status. ([af73f61](af73f61)), closes [#509](#509) * Increases burst and delay to allow a large number of status requests for the apps. ([9945be5](9945be5)), closes [#500](#500) * new pre release ([e81866c](e81866c)) * new pre release ([3028f64](3028f64)) * Restricts the content of …deployment….zip to the folders and files relevant for deployment. The previously included parent folder is now removed. ([580e551](580e551)), closes [#432](#432) [#433](#433) * update cypress to fix vulnerable dependencies and update the other npm packages to the latest versions ([38dc6c7](38dc6c7)), closes [#498](#498) ### Features * A readable code is now used for the data request to an index case. This consists of four random words and an abbreviation for the department. ([e913f8a](e913f8a)), closes [iris-connect/iris-backlog#245](https://github.com/iris-connect/iris-backlog/issues/245) [#460](#460) * Add event tracking xlsx data export for octoware, refactor and unify the data export functionality ([b442014](b442014)) * **Admin:** Docker is now told the health status of the client backend (BFF) container. Administrators can build monitoring functions on this. ([8d262ac](8d262ac)), closes [#451](#451) * Display checkin app status information in the frontend to inform the user if there are problems with a connected data provider ([c0c21f1](c0c21f1)), closes [iris-connect/iris-backlog#221](https://github.com/iris-connect/iris-backlog/issues/221) [#444](#444) * Provides excel export for event tracking standard format and improves table selection usability. ([5132b0a](5132b0a)), closes [#266](#266) [#476](#476) * Updates EPS from version v0.1.66 to v0.1.68. ([c7afbf5](c7afbf5)) * Uses and requires Java 17 (new long term support version) as baseline. ([558171b](558171b)), closes [#393](#393) * When a user changes his password, the old password is now also expected and checked to ensure it is correct. ([72af5dc](72af5dc)), closes [iris-connect/iris-backlog#250](https://github.com/iris-connect/iris-backlog/issues/250) [#431](#431)
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…number sanitization regex to support more number variants
Fixes #478