Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using path-like type instead of string for arguments to functions #123

Open
AndrooFrowns opened this issue Nov 9, 2024 · 0 comments
Assignees
Milestone

Comments

@AndrooFrowns
Copy link

In some functions such as save_to_xlsx or save_to_icalc, the functions take an argument of type &str and immediately convert to std::path::Path.

For convenience/clarity it might be worth taking either &Path as the argument type or <P: AsRef<Path> so that converting into the Path type is not required so often, and it's more clear which Strings represent paths rather than more general strings.

There is some discussion here about how to minimize the binary bloat of the monomorphized version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants