Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt missing networkInterfaceSelector in the LoadbalancerSpec of Loadbalancer Object #486

Open
Rohit-0505 opened this issue Jan 30, 2025 · 0 comments · May be fixed by #488
Open

Adapt missing networkInterfaceSelector in the LoadbalancerSpec of Loadbalancer Object #486

Rohit-0505 opened this issue Jan 30, 2025 · 0 comments · May be fixed by #488
Assignees

Comments

@Rohit-0505
Copy link
Contributor

Rohit-0505 commented Jan 30, 2025

Currently, the Loadbalancer object is missing the networkInterfaceSelector field in LoadbalancerSpec. This omission leads to unintended behavior when a Loadbalancer is created by the cloud provider:

  • When a Loadbalancer is first created without networkInterfaceSelector, it automatically selects all network interfaces within the associated network.

  • This results in a loadbalancerRouting configuration that includes destinations for all networkInterfaces.

  • If any networkInterface is later deleted, the loadbalancerRouting destinations become inconsistent, potentially leading to unexpected routing issues.

To prevent these issues, we need to introduce the networkInterfaceSelector field in LoadbalancerSpec.

Proposed changes:

As per Ironcore API design, the Loadbalancerspec must have a networkInterfaceSelector to ensure the loadbalancing across the selected networkInterfaces.

  • Add networkInterfaceSelector field in LoadbalancerSpec while creating the LoadBalancer object, and choose the appropriate label for nic in the cloud-provider-ironcore

Ensure below validations via testcases

  • Ensure that loadbalancerRouting destinations update correctly when networkIinterfaces are deleted or modified.
  • Add Test validation and error handling to prevent inconsistent loadbalancerRouting.
@github-project-automation github-project-automation bot moved this to 📋 Todo in Integration Jan 30, 2025
@Rohit-0505 Rohit-0505 moved this to 📋 Todo in Core Jan 30, 2025
@Rohit-0505 Rohit-0505 added this to Core Jan 30, 2025
@Rohit-0505 Rohit-0505 removed this from Core Jan 30, 2025
@Rohit-0505 Rohit-0505 self-assigned this Jan 30, 2025
@Rohit-0505 Rohit-0505 moved this from 📋 Todo to 🧑‍💻 In Progress in Integration Jan 30, 2025
@Rohit-0505 Rohit-0505 linked a pull request Feb 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧑‍💻 In Progress
Development

Successfully merging a pull request may close this issue.

1 participant