Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ORI Networking integration #736

Open
adracus opened this issue Apr 28, 2023 · 0 comments
Open

Enhance ORI Networking integration #736

adracus opened this issue Apr 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@adracus
Copy link
Contributor

adracus commented Apr 28, 2023

Summary

The ORI interface in the onmetal-api project includes support for load balancers, NAT gateways, and alias
prefixes. While these features can be useful in certain scenarios, they add significant complexity to the
codebase and make it harder to maintain and extend the ORI interface. Additionally, these features are not
required for all use cases of the ORI interface, which means that some users may be burdened with unnecessary
complexity.

This issue suggests trimming down the ORI interface to remove load balancers, NAT gateways, and
alias prefixes. By doing so, we can simplify the codebase and make it easier to use, maintain and implement
the ORI interface.

Motivation

The motivation for this issue is to simplify the ORI interface in the onmetal-api project. Currently, the
ORI interface includes support for load balancers, NAT gateways, and alias prefixes, which adds significant
complexity to the codebase. An ORI machine implementor should not have to care about these details but the
overall networking integration instead.

By trimming down the ORI interface to remove support for load balancers, NAT gateways, and alias prefixes, we
can simplify the codebase and make it easier to use and maintain. This will benefit all users of the onmetal-
api project.

Proposed Changes

The proposed changes to the ORI interface include:

  • Removing load balancers, NAT gateways, and alias prefixes from the ORI interface
  • Update machinepoollet, machinebroker and the internal controllers

Testing

To ensure that these changes do not introduce any regressions, we will perform the following tests:

  • Unit tests for the ORI interface will be updated to reflect the changes
  • Integration tests for the ORI interface will be updated to reflect the changes
  • Manual testing will be performed to ensure that the ORI interface works as expected without load balancers,
    NAT gateways, and alias prefixes

Conclusion

By trimming down the ORI interface to remove support for load balancers, NAT gateways, and alias prefixes, we
can simplify the codebase and make it easier to use and maintain the ORI interface.

@adracus adracus added the enhancement New feature or request label Apr 28, 2023
@adracus adracus changed the title Overhaul Networking Integration by Trimming Down ORI Interface Enhance Networking Integration by Trimming Down ORI Interface Apr 28, 2023
@adracus adracus changed the title Enhance Networking Integration by Trimming Down ORI Interface Enhance ORI Networking integration Apr 28, 2023
@afritzler afritzler added this to Core Nov 20, 2023
@afritzler afritzler moved this to Todo in Core Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant