Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit visibility of <Pool>.Status.Capacity / Allocatable #813

Closed
adracus opened this issue Aug 1, 2023 · 1 comment
Closed

Limit visibility of <Pool>.Status.Capacity / Allocatable #813

adracus opened this issue Aug 1, 2023 · 1 comment
Assignees
@lukasfrank
Labels
enhancement New feature or request

Comments

@adracus
Copy link
Contributor

adracus commented Aug 1, 2023

Summary

Currently, each user that can get / list a pool can see its Status.Capacity / Status.Allocatable.
Since this is potentially confidential information, we should enable hiding the field for users without the
<pool>/stats permission.

Example

For a MachinePool, if a user doesn't have the RBAC machinepools/stats permission, the machine pool status should not include Capacity / Allocatable. If the user has this permission, the fields should be included.
@adracus adracus added the enhancement New feature or request label Aug 1, 2023
@lukasfrank lukasfrank self-assigned this Aug 10, 2023
@lukasfrank lukasfrank mentioned this issue Sep 13, 2023
Closed
@afritzler afritzler added this to Core Nov 20, 2023
@afritzler afritzler moved this to Todo in Core Nov 20, 2023
@lukasfrank
Copy link
Member

Not needed anymore with #1128

@github-project-automation github-project-automation bot moved this from Todo to Done in Core Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasfrank lukasfrank

Labels
enhancement New feature or request
Projects
Core
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide resource visibility if user is not in defined group ironcore-dev/ironcore
2 participants
@adracus @lukasfrank