Merge pull request #1763 from isaacphysics/improvement/reduce-llm-validation-data-main

Adjust app to allow for reduced data in LLM-marked validation

Author: axlewin

src/IsaacApiTypes.tsx

@@ -370,9 +370,6 @@ export interface InlineRegionValidationResponseDTO extends QuestionValidationRes
 }
 
 export interface LLMFreeTextQuestionValidationResponseDTO extends QuestionValidationResponseDTO {
-    markCalculationInstructions?: string;
-    additionalMarkingInstructions?: string;
-    maxMarks?: number;
     marksAwarded?: number;
     markBreakdown?: LLMFreeTextMarkSchemeEntryDTO[];
 }

src/app/components/content/IsaacQuestion.tsx

@@ -76,7 +76,6 @@ export const IsaacQuestion = withRouter(({doc, location}: {doc: ApiTypes.Questio
     const [hasSubmitted, setHasSubmitted] = useState<boolean>(false);
     const hidingAttempts = useAppSelector(selectors.user.preferences)?.DISPLAY_SETTING?.HIDE_QUESTION_ATTEMPTS ?? false;
 
-
     const {confidenceState, setConfidenceState, validationPending, setValidationPending, confidenceDisabled, recordConfidence, showQuestionFeedback} = useConfidenceQuestionsValues(
         currentGameboard?.tags?.includes("CONFIDENCE_RESEARCH_BOARD"),
         "question",
@@ -289,7 +288,7 @@ export const IsaacQuestion = withRouter(({doc, location}: {doc: ApiTypes.Questio
 
         {/* LLM free-text question validation response */}
         {isLLMFreeTextQuestion && showQuestionFeedback && validationResponse && showInlineAttemptStatus && !canSubmit &&
-            <LLMFreeTextQuestionFeedbackView {...{validationResponse, hasSubmitted, sentFeedback, setSentFeedback}} />
+            <LLMFreeTextQuestionFeedbackView maxMarks={(doc as ApiTypes.IsaacLLMFreeTextQuestionDTO).maxMarks ?? 0} {...{validationResponse, hasSubmitted, sentFeedback, setSentFeedback}} />
         }
     </ConfidenceContext.Provider>;
 });

src/app/components/elements/LLMFreeTextQuestionFeedbackView.tsx

@@ -12,11 +12,12 @@ const noFeedback = {disagree: false, partlyAgree: false, agree: false};
 
 interface LLMFreeTextQuestionFeedbackViewProps {
     validationResponse: Immutable<LLMFreeTextQuestionValidationResponseDTO>;
+    maxMarks: number;
     hasSubmitted: boolean;
     sentFeedback: boolean;
     setSentFeedback: (value: boolean) => void;
 }
-export default function LLMFreeTextQuestionFeedbackView({validationResponse, hasSubmitted, sentFeedback, setSentFeedback}: LLMFreeTextQuestionFeedbackViewProps) {
+export default function LLMFreeTextQuestionFeedbackView({validationResponse, maxMarks, hasSubmitted, sentFeedback, setSentFeedback}: LLMFreeTextQuestionFeedbackViewProps) {
     const dispatch = useAppDispatch();
     const page = useAppSelector(selectors.doc.get);
     const pageId = page && page !== NOT_FOUND && page.id || undefined;
@@ -35,7 +36,7 @@ export default function LLMFreeTextQuestionFeedbackView({validationResponse, has
         <div className="prediction my-4">
             <div className='d-flex'>
                 <span className="icon-ai me-2"/>
-                <strong>{`Prediction: ${validationResponse.marksAwarded} out of ${validationResponse.maxMarks} marks`}</strong>
+                <strong>{`Prediction: ${validationResponse.marksAwarded} out of ${maxMarks} marks`}</strong>
             </div>
         </div>
         <div className="table-responsive card curved-table-wrapper mb-4">