-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subject is not a constructor #9
Comments
I can't figure out how to reproduce this. What version of rxjs are you using? And what version of Angular? It would be really helpful if you could make a small github repository that reproduced this. |
Rxjs 5.3.0 (but it does the same with 5.2.0) and Angular 4.0.1 |
Hm. I just created a sample app that works without this error. https://github.com/isaacplmann/ngx-contextmenu-test Can you modify this one or make your own that demonstrates the problem? |
I finally figured out where the problem lies, however, I am not sure what the resolution is. I am using a Node.js server and I am using systemjs to load my modules. There is some type of breaking change that happened after systemjs@0.20.0-rc.1 that is currently incompatible with ngx-contextmenu. |
Ah, so you're using systemjs to build. I'm not using that myself, so I'm afraid I'm not supporting it as well as I do webpack builds. Issue #5 should help resolve this somewhat, once I get around to it. I found an issue filed against the angular cli that might be related to what you're experiencing. Let me know if you find a solution or if you have any guidance for how I can better package the library. (PRs are always welcome.) |
Closing this in favor of #5 |
"rxjs": "^5.2.0" |
I can't seem to get rid of this error when I use the component. It doesn't seem to like that the service uses the 'Subject' from rxjs as a constructor, i.e. 'new Subject()';
The text was updated successfully, but these errors were encountered: