-
Notifications
You must be signed in to change notification settings - Fork 130
Leading zeroes should invalidate issue references #372
Comments
On 3/25/2015 1:45 AM, James Dennes (GitHub Staff) wrote:
|
Nice catch, I specially like issue: #1 Added to my test list: cirosantilli/test-git-web-interface#4 |
Note to self: don't run |
If you are typing something with # followed by a number, isn't that generally code, which should be encased in backticks like
? |
@eddiemonge Git commit messages generally don't use that much Markdown formatting. |
When writing a number preceded by an octothorpe in an issue, pull request, or commit message, the number is parsed and interpreted as a reference to an issue number. This causes problems when the number refers to something else, such as a CSS color - particularly if the color has no red and a low green value, as GitHub interprets a color like #1138 as a reference to "Issue #1138" if such an issue exists. (See github-linguist/linguist#2269 for an example of a commit that encounters this issue, where the color
#000080
is replaced with a linked "#80".)Not interpreting any number after '#' that starts with a zero would generally fix colors being misinterpreted as issue references, as that would leave only values of #100000 and up to be possibly interpreted as an issue, and very few projects (none, to my knowledge) have a hundred thousand issues.
The text was updated successfully, but these errors were encountered: