Skip to content

Commit

Permalink
minimatch@latest
Browse files Browse the repository at this point in the history
  • Loading branch information
@isaacs
isaacs committed May 19, 2014
1 parent df08d2a commit 2a8bea0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"node": "*"
},
"dependencies": {
"minimatch": "~0.2.11",
"inherits": "2"
"inherits": "2",
"minimatch": "^0.3.0"
},
"devDependencies": {
"tap": "~0.4.0",
Expand Down

9 comments on commit 2a8bea0

@paulmelnikow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit seems to break compatibility with Node v0.10.5. Were caret operators introduced afterward?

This isn't really a problem – I can upgrade to a later version, but thought I'd point it out in case others encounter the issue.

@derekr
Copy link

@derekr derekr commented on 2a8bea0 May 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this breaks on older versions of node as well 0.8.17 :/

@socketpair
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You break my web-site :( (Nodejs 0.10.4)

@jdalton
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #93 and #96.

@ksullivan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can fix this by updating your npm.
It was fixed for me when I updated my npm from 1.2.30 to 1.4.10.
sudo npm update -g npm

@jalava
Copy link

@jalava jalava commented on 2a8bea0 May 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke almost all our projects due to glob being sub-sub-dependency of many packages. We cant update npm due to "n" breaking down and we run multiple node revisions in our dev environment. At least stylus (has 3.2.x) and few others use ~ or wildcard dependencies for glob so this is breaking change and at minimum should be v3.3.0

OTOH, everyone should stop using wildcard (*, >=) on published npm packages!

@Panya
Copy link

@Panya Panya commented on 2a8bea0 May 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say everyone should use proper semver :) These changes surely should be in the minor release.

@paulmelnikow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so it looks like npm got upgraded as a side effect of installing node.

@matteofigus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade npm or node is not that easy in some situations for some people and some organisations. I don't have the permission to do it, and have been blocked for all the entire day :(

Please sign in to comment.