Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with globbing on Windows #53

Closed
kimjoar opened this issue Feb 6, 2013 · 3 comments
Closed

Problem with globbing on Windows #53

kimjoar opened this issue Feb 6, 2013 · 3 comments

Comments

@kimjoar
Copy link
Contributor

kimjoar commented Feb 6, 2013

e0829f6 appears to open up a problem on Windows. When using Git bash I work on n:\. npm, however, installs modules into c:\. This leads to the following problem:

path:  c:/Users/e5867u/AppData/Roaming/npm/node_modules/testacular/adapter/lib/jasmine.js
[ 'n:/c:/Users/e5867u/AppData/Roaming/npm/node_modules/testacular/adapter/lib/jasmine.js' ]

The problem is this: https://github.com/isaacs/node-glob/blob/master/glob.js#L326-L328

I tried printing the prefix before and after this if:

prefix before:  c:/Users/e5867u/AppData/Roaming/npm/node_modules/testacular/adapter/lib/jasmine.js
root:  n:/
prefix after:  n:\c:\Users\e5867u\AppData\Roaming\npm\node_modules\testacular\adapter\lib\jasmine.js

When going back to the code as it was before e0829f6, ie if (prefix.charAt(0) === "/" && !this.nomount) { the code returns as expected:

path:  c:/Users/e5867u/AppData/Roaming/npm/node_modules/testacular/adapter/lib/jasmine.js
[ 'c:/Users/e5867u/AppData/Roaming/npm/node_modules/testacular/adapter/lib/jasmine.js' ]
@isaacs
Copy link
Owner

isaacs commented Feb 6, 2013

I see this. Can you please try with 3.1.19? Should be fixed now.

@kimjoar
Copy link
Contributor Author

kimjoar commented Feb 7, 2013

Thanks for the fast fix @isaacs. It works great for me now!

@kimjoar
Copy link
Contributor Author

kimjoar commented Feb 7, 2013

Btw, the fix in 9b4155a includes console.logs which I did not see in my tests on Windows, e.g. https://github.com/testacular/testacular/issues/336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants