Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.x branch Broken on Node.js master #120

Closed
MylesBorins opened this issue Dec 5, 2017 · 4 comments
Closed

v3.x branch Broken on Node.js master #120

MylesBorins opened this issue Dec 5, 2017 · 4 comments

Comments

@MylesBorins
Copy link

Specifically by nodejs/node#13295

We've had to deprecate remove vm.runInDebugContext() due to the api being deprecated in V8

I'm going to dig in and see if I can come up with a patch for the 3.x branch to avoid ecosystem breakages

@isaacs
Copy link
Owner

isaacs commented Dec 5, 2017

I'm not super interested in doing work to support graceful-fs@3. But, if you want to write a patch, I'd be happy to land it and push a 3.x release. Please do also reach out to authors using it. (I've already deprecated it, so they're getting nagged as of yesterday. Should've probably done that a long time ago.)

@MylesBorins
Copy link
Author

Thanks for the quick response. This ends up breaking vinyl-fs + gulp... you know the drill. I'll see if I can come up with a quick fix, but if not I'll pass the message to the gulp team. Thankfully we have a bunch of runway to sort this out

@MylesBorins
Copy link
Author

This seems to be inherited from breakages in natives

closing in lieu of isaacs/natives#14

@renomateo
Copy link

FWIW- I got this working in v3.0.8 by installing natives and changing the relevant require's in fs.js:

// eeeeeevvvvviiiiiiillllll
// more evil than monkey-patching the native builtin?
// Not sure.

var natives = require('natives')
var mod = natives.require("module")
var pre = '(function (exports, require, module, __filename, __dirname) { '
var post = '});'
var src = pre + process.binding('natives').fs + post
var vm = natives.require('vm')
var fn = vm.runInThisContext(src)
fn(exports, natives.require, module, __filename, __dirname)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants