Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeError when loading graceful-fs from worker threads #205

Closed
wants to merge 2 commits into from
Closed

fix: TypeError when loading graceful-fs from worker threads #205

wants to merge 2 commits into from

Conversation

RomainMuller
Copy link
Contributor

Fixes #204

RomainMuller added a commit to aws/jsii that referenced this pull request Feb 8, 2021
@RomainMuller
fix(pacmak): TypeError when operating with Worker threads
6d97940 
This works around isaacs/node-graceful-fs#204, where `graceful-fs`
cannot be loaded from within `Worker` threads. Since the language
generators are loaded in worker threads whenever they are available,
they cannot use `fs-extra` which itself uses `graceful-fs`.

This is hopefully a temporary measure, until isaacs/node-graceful-fs#205
is merged & released.
@RomainMuller RomainMuller mentioned this pull request Feb 8, 2021
Merged
mergify bot pushed a commit to aws/jsii that referenced this pull request Feb 9, 2021
@RomainMuller
fix(pacmak): TypeError when operating with Worker threads (#2550)
5822e48 
This works around isaacs/node-graceful-fs#204, where `graceful-fs`
cannot be loaded from within `Worker` threads. Since the language
generators are loaded in worker threads whenever they are available,
they cannot use `fs-extra` which itself uses `graceful-fs`.
    
This is hopefully a temporary measure, until isaacs/node-graceful-fs#205
is merged & released.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@RomainMuller @coreyfarrell
Update polyfills.js
d8efccc 
Co-authored-by: Corey Farrell <git@cfware.com>
@RomainMuller
Copy link
Contributor Author

I would like this released ASAP - I find myself unable to work around the breakage at the moment, as I am getting this from fs-extra, and from the jsonfile dependency of fs-extra, and my attempts to pin graceful-fs to 4.2.4 in the consuming package still result in npm resolving to 4.2.5 for transitive dependencies. This is maddening!

@isaacs isaacs closed this in f762c74 Feb 9, 2021
This was referenced Mar 9, 2021
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyfarrell coreyfarrell coreyfarrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot be used in Worker threads (Node 10.x)
2 participants
@RomainMuller @coreyfarrell