Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for LTS versions #343

Closed
Mister-Hope opened this issue Jul 13, 2024 · 6 comments
Closed

Restore support for LTS versions #343

Mister-Hope opened this issue Jul 13, 2024 · 6 comments

Comments

@Mister-Hope
Copy link

See https://nodejs.org/en/about/previous-releases, node 18 is a valid LTS version till June 2025, so unless there are strong reasons that you must drop it, you'd better support it.

While I did not find any, this package could probably run on node18 while you are dropping it for no reason.

@kachkaev
Copy link

kachkaev commented Jul 13, 2024

I agree. Node 18 is still gonna be supported for over nine months:

Screenshot 2024-07-13 at 21 23 40

A lot of libraries depend on lru-cache and if they upgrade to v11, they will unwillingly run into problems.

@isaacs
Copy link
Owner

isaacs commented Jul 13, 2024

They won't upgrade to v11 by accident, because it's semver major.

Please stop sending this identical pr to all my repos. I chose the engines restriction deliberately.

@isaacs isaacs closed this as completed Jul 13, 2024
@kachkaev
Copy link

kachkaev commented Jul 13, 2024

I chose the engines restriction deliberately.

👋 @isaacs! What’s the motivation behind your choice? What is wrong in the currently maintained Node v18 that it can no longer be supported by lru-cache?

These questions are driven by curiosity and a desire to understand your thinking. The library is downloaded ≈175M times a week so I guess I’m not the only one who would benefit from the answer. Huge thanks for your work on lru-cache!

@isaacs
Copy link
Owner

isaacs commented Jul 13, 2024

Anyone on node 18 can keep using the previous major forever. That's fine. It's only the new version that requires a newer node.

The importer/loader behavior changed dramatically in node 20. It's too much of an annoying hassle to support both in my tests, since I use a bunch of tooling which touches that interface.

@Mister-Hope
Copy link
Author

Mister-Hope commented Jul 14, 2024

(╯-_-)╯╧╧

👎

Then I see, it is just personal taste. Just like you said in another reply note 18 is dead to you, no matter whether it's the same for community.

As an expert front end developer I believe you are understand That raising a new major that drop.some.of.the lta.version could.confuse users, but you just don't care about the community and the node ecosystem.

I've read all your major changes across all your packages and I didn't find anything that stops you supporting node18, while you still insist that you don't want to support it.

So it's not too hard to understand that all your project are mostly working by your own. :) Conversations over, have a nice life with your own.

@isaacs
Copy link
Owner

isaacs commented Jul 14, 2024

You don't care about the community and the node ecosystem.

Wow.

Feel free to not use the libraries I've created, if you can. After all, you've paid nothing for my labor, and are entitled to none of it.

Your ignorance and entitlement are astounding.

Repository owner locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants