Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark fs.promises.realpath/fs.realpath.native vs fs.realpath, fs.realpathSync vs fs.realpathSync.native #2

Open
isaacs opened this issue Feb 7, 2023 · 0 comments

Comments

@isaacs
Copy link
Owner

isaacs commented Feb 7, 2023

Right now it's using the native forms, but I seem to recall the JS one out-performing it in some scenarios, especially in the loop detection cases.

Another avenue to explore is implementing realpath in this module, but that's complicated. Most of the data is available to short-circuit some of the work in a lot of cases, probably, but in my experience it's a tricky one to get exactly right.

@isaacs isaacs changed the title benchmark fs.promises.realpath vs fs.realpath.sync, fs.realpathSync vs fs.realpathSync.native benchmark fs.promises.realpath/fs.realpath.native vs fs.realpath, fs.realpathSync vs fs.realpathSync.native Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant