Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests failing on Node 18.x for Windows Bash & PowerShell #310

Closed
ajitzero opened this issue Jun 8, 2024 · 1 comment
Closed

Tests failing on Node 18.x for Windows Bash & PowerShell #310

ajitzero opened this issue Jun 8, 2024 · 1 comment

Comments

@ajitzero
Copy link
Contributor

ajitzero commented Jun 8, 2024

Needs investigation. It must be a Node issue since the tests work in v16, v20 & v22.

Issue first seen with CI 167 which uses this commit dc3ffe5
@ajitzero ajitzero mentioned this issue Jun 8, 2024
Merged
@isaacs
Copy link
Owner

isaacs commented Jul 10, 2024

Yeah, v18 windows has some issues wiht tap, which is why i've dropped support for it in main.

@isaacs isaacs closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacs @ajitzero