Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Found "Invalid Character Entity Error" #139

Closed
dheerajaggarwal opened this issue Nov 29, 2014 · 2 comments · May be fixed by #162
Closed

Found "Invalid Character Entity Error" #139

dheerajaggarwal opened this issue Nov 29, 2014 · 2 comments · May be fixed by #162

Comments

@dheerajaggarwal
Copy link

I have followed the documentation for resolving custom entities. I am using ondoctype event to fetch the custom entities. So far it is working fine. But one of my custom entity name contains character '-' that your library doesn't permits.

Replacing the following code entity = number+letter+"#" with entity = number+letter+"#-" resolves my issue.
Please do this modification in your library.
@Koka5
Copy link

Koka5 commented Dec 6, 2014

your solution worked for me as well..!!

waiting for this modification in master...

@isaacs
Copy link
Owner

isaacs commented Dec 7, 2014

Can you send a pull request with a test? Thank you.

@khaledhosny khaledhosny mentioned this issue Dec 22, 2014
Closed
thiakil added a commit to thiakil/sax-js that referenced this issue Oct 10, 2015
@thiakil
Add test for new entity parsing. Should fix isaacs#139 & Adobe Illust…
0836892 
…rator files with _ in names.
@thiakil thiakil mentioned this issue Oct 10, 2015
Open
@isaacs isaacs closed this as completed in 150080f Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Entities Parsing thiakil/sax-js
Don't reject valid entity names
3 participants
@isaacs @dheerajaggarwal @Koka5