Skip to content

Latest commit

 

History

History
42 lines (36 loc) · 1.83 KB

pull_requests.md

File metadata and controls

42 lines (36 loc) · 1.83 KB
Raw
title
Isabelle Community Pull Request Management

Creating a Pull Request

We use a standard fork-and-branch workflow. See https://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/ for a good introduction.

Here are some tips and tricks to make the process of contributing as smooth as possible.

  1. Adhere to the guidelines described in this folder.
  2. Discuss your contribution before and while you are working on it. Create an issue to discuss your general ideas and questions. For more detailed and longer conversations, you could also make use of Isabelle's Zulip.
  3. Use /<path to isabelle>/bin/isabelle build -vD . to check if your project compiles before sending a PR
  4. Create a pull request from a feature branch on your personal fork, as explained in the link above, or from a branch of the main repository if you have commit access.
  5. If you have made a lot of changes/additions, make many PRs containing small, self-contained pieces. This helps you get feedback as you go along, and it is much easier to review. This is especially important for new contributors.
  6. Answer the following three questions in your PR:
  7. What: What is this PR about?
  8. Why: Why is this PR useful/what is the problem you solve?
  9. How: How did you create the feature/solve the problem?
  10. Check the code-review checklist below.
  11. As for commits, bugs closed by the PR should be listed on a separate line in the footer prefixed with "Closes".

Code-Review Checklist

When creating or reviewing a pull request, make sure you can tick all boxes of the following checklist:

Check:
 * [ ] coding style
 * [ ] documentation
 * [ ] for tactics:
     * [ ] tests
     * [ ] efficiency (make sure at least it's not outrageously inefficient)
 * [ ] it fits the overall library design