Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: AUX_CAL data files aren't included in a pip install #85

Closed
scottstanie opened this issue Nov 18, 2022 · 1 comment
Closed

[Bug]: AUX_CAL data files aren't included in a pip install #85

scottstanie opened this issue Nov 18, 2022 · 1 comment
Labels
bug Something isn't working needs triage Issue requires triage to proceed

Comments

@scottstanie
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Describe the bug

during testing, @gracebato noted that the aux_cal data files are not included if you do pip install git+https://github.com/opera-adt/s1-reader (which is a preview to what will happen if/when we put this on pypi).

What did you expect?

The aux cal fixing doesn't work without these data files when you install in this way.

(test39) staniewi:cslc-loading-time$ python -m pip install git+https://github.com/opera-adt/s1-reader.git
Collecting git+https://github.com/opera-adt/s1-reader.git
  Cloning https://github.com/opera-adt/s1-reader.git to /private/var/folders/hw/sj9hl8555s36n00t812twvcr0000gq/T/pip-req-build-fhe8kain
  Running command git clone --filter=blob:none --quiet https://github.com/opera-adt/s1-reader.git /private/var/folders/hw/sj9hl8555s36n00t812twvcr0000gq/T/pip-req-build-fhe8kain
...

Installing collected packages: zipp, importlib-resources, s1reader
Successfully installed importlib-resources-5.10.0 s1reader-0.1.2 zipp-3.10.0

(test39) staniewi:cslc-loading-time$ ls /Users/staniewi/miniconda3/envs/test39/lib/python3.9/site-packages/s1reader/data/
sentinel1_track_burst_id.txt

Reproducible steps

No response

Environment

No response

@scottstanie scottstanie added bug Something isn't working needs triage Issue requires triage to proceed labels Nov 18, 2022
@scottstanie
Copy link
Contributor Author

closed by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Issue requires triage to proceed
Projects
None yet
Development

No branches or pull requests

1 participant