Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for nyc.config.js #1019

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

coreyfarrell
Copy link
Member

Fixes #1018


Even without istanbuljs/istanbuljs#333 nyc.config.js will only be picked up if all: true is enabled. nyc.config.js is loaded before instrumentation hooks are setup so I think the only way to report coverage for it is to pre-instrument it and use nyc --nycrc-path nyc.config.covered.js (not sure why anyone would want that though).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.738% when pulling 101dadf on coreyfarrell:nyc-config-js into b25492a on istanbuljs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.738% when pulling 101dadf on coreyfarrell:nyc-config-js into b25492a on istanbuljs:master.

@JaKXz JaKXz merged commit 3b203c7 into istanbuljs:master Mar 11, 2019
@coreyfarrell coreyfarrell deleted the nyc-config-js branch March 13, 2019 00:00
@coreyfarrell coreyfarrell mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants