config.include not respected when paths are not in cwd, namely symlinked files

[giannic]

Expected Behavior

config.include paths override test-exclude lib's explicit ignore of parent paths, ../

Observed Behavior

Any file not in cwd is ignored.

Bonus Points! Code (or Repository) that Reproduces Issue

https://github.com/istanbuljs/test-exclude/blob/master/index.js#L60

Forensic Information

Operating System: OSX 10.10.5
Environment Information:
The caveat comes in here: I am using bazel build system to execute nyc. Bazel achieves fast reproducible builds partly by symlinking required files from a tmp directly under /private/tmp. This means any relFile path will start with ../ for any build done in bazel.

At the moment, I forked the repo with a patch just to move forward, but I would love suggestion and happy to make acceptable changes upstream if necessary

node & npm versions:
v4.6.0
2.15.9

[bcoe]

@giannic thanks for reporting this; I'd love to figure a way to better support some common edge-cases like symlinks ... while still preventing weird files from being instrumented, e.g., files outside your project ... seems like there are quite a few edge-cases that would need to be worked through.

[Wedvich]

I have a different, though probably still not very common use case, where I use multiple test frameworks for some setup examples. Basically, I have a directory structure like this:

tap-nyc
    test
        index.spec.js
    package.json
src
    index.spec.js

Using tap-nyc as the working directory, running nyc tap ./test/**/*.spec.js passes the test, but no files are discovered by nyc since it's outside the current working directory, even if I've explicitly asked for the source files to be included using config.include.

[JaKXz]

Looks like this is related to #962

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.