-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sourcemap in instrumented files #674
Conversation
@schutm I'm not sure what the best solution is here such that you and @vanduynslagerp don't consistently break each-other's use-cases. Is there a heuristic approach we could use so that both your applications of |
Agreed we shouldn't break each other changes, and test-cases should be there. However since this is in the CLI I didn't think it would break the previous changes. For now seems I had a dangling comma; which I'll fix |
Changes Unknown when pulling be893c5 on schutm:master into ** on istanbuljs:master**. |
@schutm I think this accidentally reverts https://github.com/istanbuljs/nyc/pull/667/files which would break @vanduynslagerp's use-case. |
The instrument command is now able to create an instrumented output, with a sourcemap attached.
Changes Unknown when pulling 6f83f56 on schutm:master into ** on istanbuljs:master**. |
@schutm this looks great 👍 sorry that this took so long to land. |
@schutm try this out, and let me know if it does the trick:
|
If invoked with
nyc instrument
it wasn's possible to attach the sourcemap. This created problems for me in the coverage reports created.