Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spawn-wrap to 1.4.0 #692

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Update spawn-wrap to 1.4.0 #692

merged 1 commit into from
Oct 21, 2017

Conversation

chadxz
Copy link
Contributor

@chadxz chadxz commented Oct 16, 2017

This patch upgrades nyc to spawn-wrap v1.4.0 to allow for setting a custom base path for the spawn-wrap temporary directory. This allows for more customization in the location of files created on disk, to allow for running coverage in environments where write access to the file system is limited.

I'm not actually sure why this change is required. In the nyc package.json file, the version is set to ^1.3.8, which I thought would allow 1.4.0 to install. However, when i set "nyc": "^11.2.1" in my devDependencies, and do npm i && npm ls spawn-wrap from a clean slate with no package-lock.json, I get

└─┬ nyc@11.2.1
  └── spawn-wrap@1.3.8

I'm running node v8.7.0 and npm v5.4.2

This patch upgrades nyc to spawn-wrap v1.4.0 to allow for setting a
custom base path for the spawn-wrap temporary directory. This allows for
more customization in the location of files created on disk, to allow
for running coverage in environments where write access to the file
system is limited.
@gautaz
Copy link

gautaz commented Oct 17, 2017

@chadxz Thanks for backing up the spawn-wrap proposal and following up with nyc, it also began with this nyc issue on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants