Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #81

Closed
novemberborn opened this issue Dec 7, 2015 · 6 comments · Fixed by #107
Closed

Windows support #81

novemberborn opened this issue Dec 7, 2015 · 6 comments · Fixed by #107

Comments

@novemberborn
Copy link
Contributor

Ticket to track progress. @bcoe should probably flesh this out more 😺

@sindresorhus
Copy link
Member

Would be nice if you set up Appveyor so you have continuous testing on Windows too.

@bcoe
Copy link
Member

bcoe commented Dec 10, 2015

I've made some further changes to our patched version of spawn-wrap and my testing copy of Windows now works with subprocesses \o/

Once the test rewrite is finished, we should try the new test-suite out on Windows and see what additional work would be needed to get things working on AppVeyor.

We should also work on getting on the master branch of spawn-wrap again, we've deviated quite a bit:

istanbuljs/spawn-wrap#5 -- I can try to prod @isaacs, I know he's not super excited to dive back into this codebase :D

CC: @novemberborn, @jamestalmage

@novemberborn
Copy link
Contributor Author

Once the test rewrite is finished, we should try the new test-suite out on Windows and see what additional work would be needed to get things working on AppVeyor.

Sounds good.

@jamestalmage
Copy link
Member

@bcoe

If you want to open up an AppVeyor account I can help track down any issues it introduces (that was one of my first contributions to AVA).

AppVeyor makes it a bit of a pain to add team members (when compared to Travis), here were the instructions I hunted down and sent to @sindresorhus. I think these worked out OK.

  1. Click your name in the upper-right for a drop-down
  2. Choose “Team”
  3. Choose “Add Role” - name it avaor something.
  4. Choose some permissions
  5. Back on the “Team” page add a Collaborator and assign the role
  6. Go to the project settings and enable the Role

Also, you will need the e-mail I used when signing up for AppVeyor (I foolishly did not use my public email). Sent via gitter.

@bcoe
Copy link
Member

bcoe commented Dec 15, 2015

@jamestalmage I've created an appveyor project for nyc:

#96

What email address do you use on AppVeyor, I'll add you to the org.

@jamestalmage
Copy link
Member

Sent via Gitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants