chore(deps): bump v8-to-istanbul from 1.2.1 to 4.1.4 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 167
💛 - Coveralls |
|
Hmm, when I try to use this all my files get 100% covered. It just flags each line as completely covered :/ According to line 147 in v8-to-istanbul's v8-to-istanbul.js file all lines start with a coverage of |
|
@skerit good catch, sounds like we can't merge this just yet. It might be worth coordinating a bit with puppeteer, to see if we can get output that's closer to the raw V8 output? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is breaking due to the required
loadmethod of the async source-map dependency. Changing the public interface of write to async has its advantages of later upgrading/updating the file system parts to async/promises.Updated Travis to use the maintenance LTS (node 10 which will be EOL 2021-04-30), see https://nodejs.org/en/about/releases/ for more info.
Fixes #49