Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore hint to support other content as well #203

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

AriPerkkio
Copy link
Contributor

@AriPerkkio AriPerkkio commented Dec 13, 2022

Adds support for ignore hints to contain more text content, e.g. reasoning for ignoring code.

Changes the patterns to check the start of the ignore hint only. No need to verify that the pattern actually stops. If this method does not work, let me know and I'll reimplement the patterns.

Closes bcoe/c8#181.

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the contribution.

@bcoe bcoe added the ci label Feb 14, 2023
@bcoe bcoe merged commit 65e70d1 into istanbuljs:master Feb 14, 2023
@AriPerkkio AriPerkkio deleted the fix/ignore-hint-extend-pattern branch February 14, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support for reason in c8 ignore comments
2 participants