-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status field to API #2900
Comments
cc @therealmitchconnors who I recall tried to add this for Istio resources, also cc @howardjohn |
Istio resources already have a status field, which we mostly do not use. I like this idea, but it will require careful API design. For starters, I would consider using kstatus compatible conditions, unless there is a compelling reason to roll our own. |
Thank you @linsun @therealmitchconnors. Is this where gateway status is updated? |
Yes but only k8s Gateway. Istio status has been a bit different to date |
We need a way to communicate to the user that the CR is misconfigured. Also, whether or not a Gateway exists in order to implement Policy Attachment correctly (see here).
Task:
The status of the targetRef referenced Gateway needs to be exposed to the controller responsible for applying policy. (One idea is to add a status field to Istio/api, but we should also consider existing solutions that may exist (e.g. kstatus)).
The text was updated successfully, but these errors were encountered: