-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve API documentation to explain sourceLabels and sourceNamespaces are selectors, not filters #3258
Comments
Interesting. I am actually not sure this is obviously the wrong behavior (certainly is under-specified). I can see the argument it should 404 - any other unmatched rule would, so why not sourceLabels? However, this and sourceNamespace are not like other match rules; probably, they should not have been under |
Got it, thank you for the clarification @howardjohn! It would definitely be helpful to note the behavior explicitly in the documentation. (Imho the hint is great but it makes you double guess how it really works) |
Is this the right place to submit this?
Bug Description
If we match route by
sourceLabels
only and the label is not present in original pod then istio routes the request to k8s service (round robin across all subsets) instead of returning 404.If I use
queryParams
instead ofsourceLabels
then istio returns 404 as expected.The issue is reproducible in 1.22.0
Testing with label:
Testing without label:
Version
Additional Information
The text was updated successfully, but these errors were encountered: