Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm API tracking issue #35607

Closed
9 of 10 tasks
dgn opened this issue Oct 14, 2021 · 15 comments
Closed
9 of 10 tasks

Wasm API tracking issue #35607

dgn opened this issue Oct 14, 2021 · 15 comments
Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@dgn
Copy link
Contributor

dgn commented Oct 14, 2021

Needed for 1.12:

Future:

@mathetake
Copy link
Member

How about "image pull secrets"? Is that removed from the scope of 1.12? cc @mandarjog @bianpengyuan

@mandarjog
Copy link
Contributor

If we get it in, that would be great. But it is not blocking .

@dgn
Copy link
Contributor Author

dgn commented Oct 18, 2021

If we get it in, that would be great. But it is not blocking .

+1 to that. I'll add it to the list

@mathetake
Copy link
Member

and signature verification #32002 (cc @asraa) should also be tracked here

@mathetake
Copy link
Member

#35683 this should also be merged in 1.12

@mathetake
Copy link
Member

blog PR: istio/istio.io#10530

@mathetake
Copy link
Member

I realized that we haven't implemented "ImagePullPolicy" as well in imagefetcher.go https://github.com/istio/api/blob/master/extensions/v1alpha1/wasm.proto#L214

@mathetake
Copy link
Member

anyone working on imagePullSecrets? (I won't be able to work neither on Istio or Envoy for a next few months or maybe a year, it would be great if someone can work on it)

@bianpengyuan
Copy link
Contributor

I am working on it now, will also implement the pull policy.

@mathetake
Copy link
Member

great! Thanks @bianpengyuan

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Apr 6, 2022
@mathetake mathetake removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Apr 6, 2022
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Apr 6, 2022
@zirain
Copy link
Member

zirain commented Apr 6, 2022

not stale

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Apr 6, 2022
@ingwonsong
Copy link
Contributor

ingwonsong commented May 9, 2022

Image pull policy was cherrypicked in 1.14!

@edieYoung
Copy link
Contributor

Is ImagePullSecret released in 1.13?

@ingwonsong
Copy link
Contributor

Is ImagePullSecret released in 1.13?

No. 1.14 will enclose it.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Aug 12, 2022
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-05-13. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Development

No branches or pull requests

8 participants