-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm API tracking issue #35607
Comments
How about "image pull secrets"? Is that removed from the scope of 1.12? cc @mandarjog @bianpengyuan |
If we get it in, that would be great. But it is not blocking . |
+1 to that. I'll add it to the list |
#35683 this should also be merged in 1.12 |
blog PR: istio/istio.io#10530 |
I realized that we haven't implemented "ImagePullPolicy" as well in imagefetcher.go https://github.com/istio/api/blob/master/extensions/v1alpha1/wasm.proto#L214 |
anyone working on imagePullSecrets? (I won't be able to work neither on Istio or Envoy for a next few months or maybe a year, it would be great if someone can work on it) |
I am working on it now, will also implement the pull policy. |
great! Thanks @bianpengyuan |
not stale |
Image pull policy was cherrypicked in 1.14! |
Is ImagePullSecret released in 1.13? |
No. 1.14 will enclose it. |
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-05-13. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions. Created by the issue and PR lifecycle manager. |
Needed for 1.12:
Future:
The text was updated successfully, but these errors were encountered: