Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterate on close connections which violate policy after updates #798

Open
1 of 3 tasks
ilrudie opened this issue Feb 5, 2024 · 3 comments
Open
1 of 3 tasks

iterate on close connections which violate policy after updates #798

ilrudie opened this issue Feb 5, 2024 · 3 comments

Comments

@ilrudie
Copy link
Contributor

ilrudie commented Feb 5, 2024

  • improved test coverage needed
  • investigate if locking can be reduced in connection manager
    • use a different channel type, preferably one which exposes a reference count
    • use a different data structure instead of Arc<RwLock<HashMap<...>>>>, maybe (DashMap)
  • replace the current release functionality with Drop to reduce likelihood of misuse/leaks

related #772 and #311

@howardjohn
Copy link
Member

Consider using Drop for release to prevent any ability to miss it

@ilrudie
Copy link
Contributor Author

ilrudie commented Apr 20, 2024

#939 adds drop semantics to handle release

@ilrudie
Copy link
Contributor Author

ilrudie commented Apr 20, 2024

Ben has proposed using flurry in #931, probably use that instead of adding a second concurrent map crate unless there's a really good reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants