Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ztunnel heap instrumentation #863

Open
1 of 2 tasks
bleggett opened this issue Apr 2, 2024 · 5 comments
Open
1 of 2 tasks

Enhance ztunnel heap instrumentation #863

bleggett opened this issue Apr 2, 2024 · 5 comments

Comments

@bleggett
Copy link
Contributor

bleggett commented Apr 2, 2024

Right now ztunnel exposes gperftools endpoints for both profiles and heaps, as well as a standard pprof profile.

ATM the gperftools endpoints don't work very well, or at all.

We should probably consolidate on 1 profiler and one heap dumper, and make sure they both work - whether that's gperftools or something else (jemalloc was mentioned).

Whatever we DO pick needs to work equally well on arm64 and amd64, and needs to support remote analysis, ideally.

@bleggett
Copy link
Contributor Author

bleggett commented Apr 2, 2024

Yep, using https://github.com/polarsignals/rust-jemalloc-pprof, seems to work well enough.

@ilrudie
Copy link
Contributor

ilrudie commented Apr 3, 2024

should #865 close this one out?

@bleggett bleggett changed the title Support heap dumps / fix gperftools Enhance ztunnel heap instrumentation Apr 3, 2024
@bleggett
Copy link
Contributor Author

bleggett commented Apr 3, 2024

@ilrudie In #865 we discussed using jemalloc as an always-on thing, or at least enabled by default for non-release builds.

I added that as another ticket item here, so we can keep this open for that.

@daixiang0
Copy link
Member

seems the second task has be completed, maybe we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants