Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-kernel/pf-sources: pkg_pretend conditions assumes lexicographic ordering. #130

Open
imaspacepirate opened this issue Jul 9, 2020 · 0 comments

Comments

@imaspacepirate
Copy link

imaspacepirate commented Jul 9, 2020

I'll start off by saying that I have been using your Gentoo overlay for several years now and thanks for all your work.

Now, there's a slight issue (that is most likely present in other builds). In your sys-kernel/pf-sources ebuilds you have the following:

pkg_pretend() {
        # 547868
(*)        if [[ $(gcc-version) < 10.0 ]]; then
                        eerror ""
                        eerror "${P} needs an active GCC 4.9+ compiler"
                        eerror ""
                        die "${P} needs an active sys-devel/gcc >= 4.9"
        fi
}

The line highlighted with (*) executes for versions of GCC >= 10 as the ‘<’ and ‘>’ operators sort lexicographically using the current locale (more information here). This is a common bug and has been documented by other Gentoo users here for example (in the section named gcc-config bug).

The fix to this issue has been detailed here. Please implement this fix. If you need help let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant