-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency vite to v5.4.12 [security] #725
chore(deps): update dependency vite to v5.4.12 [security] #725
Conversation
Warning Rate limit exceeded@renovate[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 36 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe pull request involves a minor update to the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
refarch-webcomponent/package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (1)
refarch-webcomponent/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (refarch-backend)
🔇 Additional comments (2)
refarch-webcomponent/package.json (2)
37-37
: Verify compatibility with related dependencies.The Vite update appears compatible with your current setup, including
@vitejs/plugin-vue
(5.2.1) andvite-plugin-vue-devtools
(7.7.0).Run this script to check for any reported compatibility issues:
✅ Verification successful
Dependencies are compatible ✅
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility between Vite 5.4.12 and related packages echo "Checking npm for known compatibility issues..." npm info vite@5.4.12 peerDependencies npm info @vitejs/plugin-vue@5.2.1 peerDependencies npm info vite-plugin-vue-devtools@7.7.0 peerDependenciesLength of output: 525
37-37
: LGTM! Important security update.This update addresses CVE-2025-24010, which fixes a vulnerability in the Vite development server's CORS settings and WebSocket connections.
To ensure secure configuration after the update, run this script to check if any custom CORS or server settings exist that might need review:
✅ Verification successful
Security update is safe to apply, no configuration changes needed
The Vite configuration in your project uses default security settings and local-only proxy configurations. The security improvements from version 5.4.12 will be automatically applied without any conflicts with your current setup.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for custom Vite server configurations that might need review # after the security update echo "Checking for Vite config files..." fd -e ts -e js -e mjs "vite.config" echo -e "\nChecking for custom server configurations..." rg -l "server: {|server:|cors:|hmr:"Length of output: 444
Script:
#!/bin/bash echo "=== Content of refarch-webcomponent/vite.config.ts ===" cat refarch-webcomponent/vite.config.ts echo -e "\n=== Searching for server configurations with fixed regex ===" rg "server[[:space:]]*:|cors[[:space:]]*:|hmr[[:space:]]*:" refarch-webcomponent/vite.config.tsLength of output: 1586
6215aa3
to
97c5947
Compare
97c5947
to
2e06382
Compare
Seems like we are not affected here because we don't serve the webcomponent template behind the API gateway. However we might need to add the allowedHost later on when we fire HTTP Requests from the webcomponents, but we will see then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the following updates:
5.4.11
->5.4.12
GitHub Vulnerability Alerts
CVE-2025-24010
Summary
Vite allowed any websites to send any requests to the development server and read the response due to default CORS settings and lack of validation on the Origin header for WebSocket connections.
Upgrade Path
Users that does not match either of the following conditions should be able to upgrade to a newer version of Vite that fixes the vulnerability without any additional configuration.
localhost
or*.localhost
Using the backend integration feature
If you are using the backend integration feature and not setting
server.origin
, you need to add the origin of the backend server to theserver.cors.origin
option. Make sure to set a specific origin rather than*
, otherwise any origin can access your development server.Using a reverse proxy in front of Vite
If you are using a reverse proxy in front of Vite and sending requests to Vite with a hostname other than
localhost
or*.localhost
, you need to add the hostname to the newserver.allowedHosts
option. For example, if the reverse proxy is sending requests tohttp://vite:5173
, you need to addvite
to theserver.allowedHosts
option.Accessing the development server via a domain other than
localhost
or*.localhost
You need to add the hostname to the new
server.allowedHosts
option. For example, if you are accessing the development server viahttp://foo.example.com:8080
, you need to addfoo.example.com
to theserver.allowedHosts
option.Using a plugin / framework that connects to the WebSocket server on their own from the browser
If you are using a plugin / framework, try upgrading to a newer version of Vite that fixes the vulnerability. If the WebSocket connection appears not to be working, the plugin / framework may have a code that connects to the WebSocket server on their own from the browser.
In that case, you can either:
legacy.skipWebSocketTokenCheck: true
to opt-out the fix for [2] while the plugin / framework is incompatible with the new version of ViteMitigation without upgrading Vite
[1]: Permissive default CORS settings
Set
server.cors
tofalse
or limitserver.cors.origin
to trusted origins.[2]: Lack of validation on the Origin header for WebSocket connections
There aren't any mitigations for this.
[3]: Lack of validation on the Host header for HTTP requests
Use Chrome 94+ or use HTTPS for the development server.
Details
There are three causes that allowed malicious websites to send any requests to the development server:
[1]: Permissive default CORS settings
Vite sets the
Access-Control-Allow-Origin
header depending onserver.cors
option. The default value wastrue
which setsAccess-Control-Allow-Origin: *
. This allows websites on any origin tofetch
contents served on the development server.Attack scenario:
http://malicious.example.com
).fetch('http://127.0.0.1:5173/main.js')
request by JS in that malicious web page. This request is normally blocked by same-origin policy, but that's not the case for the reasons above.http://127.0.0.1:5173/main.js
.[2]: Lack of validation on the Origin header for WebSocket connections
Vite starts a WebSocket server to handle HMR and other functionalities. This WebSocket server did not perform validation on the Origin header and was vulnerable to Cross-Site WebSocket Hijacking (CSWSH) attacks. With that attack, an attacker can read and write messages on the WebSocket connection. Vite only sends some information over the WebSocket connection (list of the file paths that changed, the file content where the errored happened, etc.), but plugins can send arbitrary messages and may include more sensitive information.
Attack scenario:
http://malicious.example.com
).new WebSocket('http://127.0.0.1:5173', 'vite-hmr')
by JS in that malicious web page.[3]: Lack of validation on the Host header for HTTP requests
Unless
server.https
is set, Vite starts the development server on HTTP. Non-HTTPS servers are vulnerable to DNS rebinding attacks without validation on the Host header. But Vite did not perform validation on the Host header. By exploiting this vulnerability, an attacker can send arbitrary requests to the development server bypassing the same-origin policy.http://malicious.example.com:5173
) (HTTPS won't work).fetch('/main.js')
request by JS in that malicious web page.http://127.0.0.1:5173/main.js
bypassing the same origin policy.Impact
[1]: Permissive default CORS settings
Users with the default
server.cors
option may:server.proxy
may have those functionalities.[2]: Lack of validation on the Origin header for WebSocket connections
All users may get the file paths of the files that changed and the file content where the error happened be stolen by malicious websites.
For users that is using a plugin that sends messages over WebSocket, that content may be stolen by malicious websites.
For users that is using a plugin that has a functionality that is triggered by messages over WebSocket, that functionality may be exploited by malicious websites.
[3]: Lack of validation on the Host header for HTTP requests
Users using HTTP for the development server and using a browser that is not Chrome 94+ may:
server.proxy
may have those functionalities.Chrome 94+ users are not affected for [3], because sending a request to a private network page from public non-HTTPS page is forbidden since Chrome 94.
Related Information
Safari has a bug that blocks requests to loopback addresses from HTTPS origins. This means when the user is using Safari and Vite is listening on lookback addresses, there's another condition of "the malicious web page is served on HTTP" to make [1] and [2] to work.
PoC
[2]: Lack of validation on the Origin header for WebSocket connections
react
template which utilizes HMR functionality.http://localhost:5173/
) as well as the malicious page in the browser.src/App.jsx
file and intentionally place a syntax errorHere's a video demonstrating the POC:
vite-cswsh.mov
Release Notes
vitejs/vite (vite)
v5.4.12
Compare Source
Please refer to CHANGELOG.md for details.
Configuration
📅 Schedule: Branch creation - "" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.