Merge pull request #3 from it-praktyk/v0.9.9

it-praktyk · web-flow · commit 3babab5a70ab · 2017-05-16T23:32:48.000+02:00
v.0.9.9
diff --git a/Help/New-OutputFile.md b/Help/New-OutputFile.md
@@ -280,10 +280,6 @@ CURRENT VERSION
 HISTORY OF VERSIONS  
 https://github.com/it-praktyk/New-OutputObject/VERSIONS.md
 
-REMARKS
-- The warning generated by PSScriptAnalyzer "Function 'New-OutputFile' has verb that could change system state.
-Therefore, the function has to support 'ShouldProcess'." is acceptable.
-
 LICENSE
 Copyright (c) 2016 Wojciech Sciesinski  
 This function is licensed under The MIT License (MIT)  
diff --git a/Help/New-OutputFolder.md b/Help/New-OutputFolder.md
@@ -262,10 +262,6 @@ CURRENT VERSION
 HISTORY OF VERSIONS  
 https://github.com/it-praktyk/New-OutputObject/VERSIONS.md
 
-REMARKS
-- The warning generated by PSScriptAnalyzer "Function 'New-OutputFolder' has verb that could change system state.
-Therefore, the function has to support 'ShouldProcess'." is acceptable.
-
 LICENSE
 Copyright (c) 2016 Wojciech Sciesinski  
 This function is licensed under The MIT License (MIT)  
diff --git a/Help/New-OutputObject.md b/Help/New-OutputObject.md
@@ -304,10 +304,6 @@ CURRENT VERSION
 HISTORY OF VERSIONS  
 https://github.com/it-praktyk/New-OutputObject/VERSIONS.md
 
-REMARKS
-- The warning generated by PSScriptAnalyzer "Function 'New-OutputFile' has verb that could change system state.
-Therefore, the function has to support 'ShouldProcess'." is acceptable.
-
 LICENSE
 Copyright (c) 2016 Wojciech Sciesinski  
 This function is licensed under The MIT License (MIT)  
diff --git a/New-OutputObject.psd1 b/New-OutputObject.psd1
diff --git a/New-OutputObject.psm1 b/New-OutputObject.psm1
@@ -21,6 +21,7 @@
 
 #>
 
+Set-StrictMode -Version Latest
 
 #Get public and private function definition files
 $Public  = @( Get-ChildItem -Path $PSScriptRoot\Public\*.ps1 -ErrorAction SilentlyContinue )
diff --git a/Private/Test-CharsInPath.ps1 b/Private/Test-CharsInPath.ps1
@@ -65,7 +65,7 @@
     # http://powershell.com/cs/blogs/tips/archive/2016/04/20/finding-invalid-file-and-path-characters.aspx
 
     CURRENT VERSION
-    - 0.5.3 - 2016-11-07
+    - 0.5.4 - 2016-11-07
 
     HISTORY OF VERSIONS
     https://github.com/it-praktyk/New-OutputObject/VERSIONS.md
@@ -132,11 +132,15 @@
 
         ElseIf ($PathType -eq 'String') {
 
+            [String]$DirectoryPath = ""
+
             #Convert String to Array of chars
             $PathArray = $Path.ToCharArray()
 
             $PathLength = $PathArray.Length
 
+            #It should be removed in a future and for loop changed to $i--
+            #Reverse PathArray to speedup of finding the folder indicator chars '\' or '/'
             [array]::Reverse($PathArray)
 
             For ($i = 0; $i -lt $PathLength; $i++) {
@@ -172,7 +176,7 @@
 
         }
 
-        [String]$MessageText = "The path provided as a string was devided to: directory part: {0} ; file name part: {1} ." -f $DirectoryPath, $FileName
+        [String]$MessageText = "The path provided as a string was divided to: directory part: {0} ; file name part: {1} ." -f $DirectoryPath, $FileName
 
         Write-Verbose -Message $MessageText
 
@@ -236,7 +240,7 @@
             Return 1
 
         }
-        #>
+
         elseif ($IncorectCharFundInPath) {
 
             Return 2
diff --git a/Public/New-OutputFile.ps1 b/Public/New-OutputFile.ps1
@@ -131,15 +131,11 @@ Function New-OutputFile {
     KEYWORDS: PowerShell, File, FileSystem
 
     CURRENT VERSION
-    - 0.9.8 - 2017-05-06
+    - 0.9.9 - 2017-05-16
 
     HISTORY OF VERSIONS
     https://github.com/it-praktyk/New-OutputObject/VERSIONS.md
 
-    REMARKS
-    - The warning generated by PSScriptAnalyzer "Function 'New-OutputFile' has verb that could change system state.
-    Therefore, the function has to support 'ShouldProcess'." is acceptable.
-
     LICENSE
     Copyright (c) 2016 Wojciech Sciesinski
     This function is licensed under The MIT License (MIT)
@@ -148,6 +144,7 @@ Function New-OutputFile {
     #>
 
     [cmdletbinding()]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseShouldProcessForStateChangingFunctions','')]
     [OutputType([System.Object[]])]
     param (
         [parameter(Mandatory = $false)]
diff --git a/Public/New-OutputFolder.ps1 b/Public/New-OutputFolder.ps1
@@ -126,14 +126,11 @@ Function New-OutputFolder {
     KEYWORDS: PowerShell, Folder, FileSystem
 
     CURRENT VERSION
-    - 0.9.8 - 2017-05-06
+    - 0.9.9 - 2017-05-16
 
     HISTORY OF VERSIONS
     https://github.com/it-praktyk/New-OutputObject/VERSIONS.md
 
-    REMARKS
-    - The warning generated by PSScriptAnalyzer "Function 'New-OutputFolder' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'." is acceptable.
-
     LICENSE
     Copyright (c) 2016 Wojciech Sciesinski
     This function is licensed under The MIT License (MIT)
@@ -142,6 +139,7 @@ Function New-OutputFolder {
     #>
 
     [cmdletbinding()]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseShouldProcessForStateChangingFunctions','')]
     [OutputType([System.Object[]])]
     param (
         [parameter(Mandatory = $false)]
@@ -184,8 +182,6 @@ Function New-OutputFolder {
 
         DateTimePartFormat = $DateTimePartFormat
 
-        OutputFileNameExtension = $OutputFolderNameExtension
-
         NamePartsSeparator = $NamePartsSeparator
 
         BreakIfError = $BreakIfError
diff --git a/Public/New-OutputObject.ps1 b/Public/New-OutputObject.ps1
@@ -144,15 +144,11 @@ Function New-OutputObject {
     KEYWORDS: PowerShell, File, Folder, FileSystem
 
     CURRENT VERSION
-    - 0.9.8 - 2017-05-06
+    - 0.9.9 - 2017-05-16
 
     HISTORY OF VERSIONS
     https://github.com/it-praktyk/New-OutputObject/VERSIONS.md
 
-    REMARKS
-    - The warning generated by PSScriptAnalyzer "Function 'New-OutputFile' has verb that could change system state.
-    Therefore, the function has to support 'ShouldProcess'." is acceptable.
-
     LICENSE
     Copyright (c) 2016 Wojciech Sciesinski
     This function is licensed under The MIT License (MIT)
@@ -161,6 +157,7 @@ Function New-OutputObject {
     #>
 
     [cmdletbinding()]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseShouldProcessForStateChangingFunctions','')]
     [OutputType([System.Object[]])]
     param (
         [parameter(Mandatory = $true)]
diff --git a/README.md b/README.md
@@ -38,7 +38,7 @@ Functions from the New-OutputObject don't
 
 Your comments - preferable via GitHub issues - and  pull requests are welcomed.
 
-The current module version: 0.9.8 - 2017-05-06.  
+The current module version: 0.9.9 - 2017-05-16.  
 The history of versions you can find [here](VERSIONS.md).
 
 The module you can download directly from GitHub or  from the [PowerShellGallery](https://www.powershellgallery.com/packages/New-OutputObject/).
diff --git a/TODO.md b/TODO.md
@@ -27,6 +27,7 @@ Alligned to the version 0.9.8 - 2017-05-06
 
 ## Test-CharsInPath
 
+- replace a for loop what split path to directory/file to decreasing counter
 - add support for an input from pipeline
 - add support to return array of incorrect chars and them positions in string
 - add support to verifying if non-english chars are used - displaying error/warning, returning other exit code
diff --git a/Tests/New-OutputObject-Module-Specific.Tests.ps1 b/Tests/New-OutputObject-Module-Specific.Tests.ps1
@@ -14,7 +14,7 @@
     https://www.linkedin.com/in/sciesinskiwojciech
 
     CURRENT VERSION
-    - 0.9.7 - 2017.05.02
+    - 0.9.8 - 2017.05.02
 
     HISTORY OF VERSIONS
     https://github.com/it-praktyk/New-OutputObject/VERSIONS.md
@@ -24,7 +24,6 @@
 
 $ModuleName = "New-OutputObject"
 
-#Provided path asume that your module manifest (a file with the psd1 extension) exists in the parent directory for directory where test script is stored
 $RelativePathToModuleRoot = "{0}\.." -f $PSScriptRoot
 $RelativePathToModuleManifest = "{0}\{1}.psd1" -f $RelativePathToModuleRoot, $ModuleName
 
@@ -119,7 +118,7 @@ $Scripts = Get-ChildItem "$here\..\" -Filter "*.ps1" -Recurse | Where-Object {$_
 
 $Modules = Get-ChildItem "$here\..\" -Filter "*.psm1" -Recurse
 
-$Excluderules = @("PSShouldProcess","PSUseShouldProcessForStateChangingFunctions")
+$Excluderules = @()
 
 $Rules = Get-ScriptAnalyzerRule | Where-Object -FilterScript { $_.RuleName -notin $Excluderules }
 
diff --git a/VERSIONS.md b/VERSIONS.md
