Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coupon feedback #623

Open
janbec opened this issue Mar 5, 2019 · 4 comments
Open

coupon feedback #623

janbec opened this issue Mar 5, 2019 · 4 comments

Comments

@janbec
Copy link

janbec commented Mar 5, 2019

Customer check

image

We can't do that check because:

  • The coupon is a gift and buyer is not necessarily the consumer
  • We may not always set customer when selling a coupon

I think we don't need to the partner_id field in coupon as we have seller and consumer on record through pos.order partner_id

Prohibit double usage

image
Currently a coupon can be used twice.

Selling coupons selection

We should only be allowed to sell coupons with fixed amount

Consuming coupons other than fixed_amount

Since we are checking for sold, this is not possible currently. However, the 10% feature is already implemented and I would like to keep. Therefore, I suggest to just post a warning if pos_product_id is set and coupon is not sold.

I was going to write on how to exclude specific_product and cheapest_product, but they all work, nice!

Add coupon sales to view

image

free product

Currently, I can’t use reward_type ‘product’. Would it be possible to pass the reward_product_id in that case?

Minimum amount and minimum qty

Is it possible to check for rule_minimum_amount and rule_min_quantity before applying coupon?
--> If this is a huge amount of extra work, don’t do it.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@janbec
Copy link
Author

janbec commented Mar 5, 2019

@ilmir-k @GabbasovDinar
I posted my feedback here

@ilmir-k
Copy link
Member

ilmir-k commented Mar 6, 2019

@janbec
Ok, got it

@janbec
Copy link
Author

janbec commented Mar 22, 2019

reward line product

I think it would be better to use the built-in reward line product for consuming a coupon and the pos_product (maybe rename it purchase_product) for buying a coupon. This would

  • make it easier to report
  • make it easier to read on pos receipt

Can we use reward line product with proper amount in PoS?

pos only accepts sold coupons

Currently only sold coupons can be consumed via PoS closing the door for promotions, giveaways or customer benefits. Therefore, I would like to double back and only apply the "is sold?" logic to coupon programs that are marked as "force sale before consumption" [bool on coupon program?]. This would then be the case and a security for vouchers we sell while enabling the pos to take part in promotions with free products and discount...

@janbec
Copy link
Author

janbec commented Mar 29, 2019

@ilmir-k @GabbasovDinar
Both modules passed testing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants