Fixed profile editing #3160
Open
Fixed profile editing #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he input Professionalsummary
|
PavloButynets
requested review from
ShadowOfTheSpace,
luiqor,
Made1ra,
ArtemHolikov,
amoutens and
SofiiaYevush
and removed request for
ShadowOfTheSpace and
luiqor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on Backend PR #1180.
Merge the backend PR first to avoid breaking changes.
When sending a request to the server, the entire
profileStateobject was sent, even those fields that were not edited, so a validation error occurred on the server because some fields (for example,professionalSummary,nativeLanguage) were empty strings. I also found another bug, when a user wanted to clearprofessionalSummaryornativeLanguage, he could not do it, because a request was also sent with an empty string and an error was thrown on the server. I implemented the request in such a way that only those fields that have changed are sent, and if the field is an empty string (“”), then null is sentPR_3160.mp4
PR_3160.2.mp4