Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh button beside "Refresh page to play again" message #26

Open
sohammondal opened this issue Oct 1, 2019 · 4 comments
Open

Refresh button beside "Refresh page to play again" message #26

sohammondal opened this issue Oct 1, 2019 · 4 comments

Comments

@sohammondal
Copy link
Contributor

No description provided.

@konsvasi
Copy link
Contributor

konsvasi commented Oct 1, 2019

I will work on this issue.

@sohammondal
Copy link
Contributor Author

@konsvasi Hey, I have already raised a PR #27 for this. You can work on other issues.

@sohammondal sohammondal mentioned this issue Oct 1, 2019
Open
@itaditya
Copy link
Owner

itaditya commented Oct 1, 2019 •
edited
Loading

I think @aelamel has also implemented this although he actually prevents window to reload.

However I find my solution here to be most simple. #34

What do you people think?

@itaditya itaditya mentioned this issue Oct 5, 2019
Closed
@itaditya
Copy link
Owner

itaditya commented Oct 5, 2019

I recently got a PR to add service worker to the game. With service workers, all game assets will be cached, and so even if we do window.reload() from a button, it will be very quick. So I'm waiting for the service worker PR to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@konsvasi @itaditya @sohammondal