Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open external links in new tabs #189

Open
bfabio opened this issue May 27, 2021 · 4 comments
Open

Open external links in new tabs #189

bfabio opened this issue May 27, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted This issue is a good one for external contributors

Comments

@bfabio
Copy link
Member

bfabio commented May 27, 2021

The external links should be opened in a new tab, possibly with noopener and noreferrer, and checked for the needed accessibility attributes.

@bfabio bfabio added enhancement New feature or request help wanted This issue is a good one for external contributors good first issue Good for newcomers labels May 27, 2021
@andreanironi
Copy link

Sorry, just spotted this issue and I'm wondering if the new tab requirement is a good idea. We investigated this on another project some time ago, and decided to step away from it after reading several advices against it, as it seems to be disrupting the mobile experience for visitors. See for instance: https://www.nngroup.com/articles/new-browser-windows-and-tabs/

I fully agree on the rest of the ticket though.

@bfabio
Copy link
Member Author

bfabio commented Sep 28, 2021

@andreanironi that's actually a really good point 🤔

@libremente
Copy link
Member

That's true @andreanironi, but we also have to consider that this website is not really intended to be used in a mobile environment. WDYT @bfabio?

@bfabio
Copy link
Member Author

bfabio commented Sep 28, 2021

@libremente I think ideally we should try and follow the guideline in that article (which is superbly written, btw, thanks @andreanironi for the link)

Summing It Up: What to Do and When

For the most part, always open links in the same browser tab or window. [...]

Right now we're kind of forcing a certain flow to the user, which is the flow we think makes sense to us but on a second thought it might not to everyone.

Anyway, I'd defer that to our UX experts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted This issue is a good one for external contributors
Projects
None yet
Development

No branches or pull requests

3 participants