Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in the program #280

Open
DLPerf opened this issue Aug 19, 2021 · 1 comment
Open

Performance issues in the program #280

DLPerf opened this issue Aug 19, 2021 · 1 comment
Assignees
Labels

Comments

@DLPerf
Copy link

DLPerf commented Aug 19, 2021

Hello,I found a performance issue in the definition of tensorflow_session ,
itdxer/neupy/blob/master/neupy/utils/tf_utils.py,
session = tf.Session(config=config) was repeatedly called and was not closed.
I think it will increase the efficiency and avoid out of memory if you close this session after using it.

Here are two files to support this issue,support1 and support2

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@itdxer
Copy link
Owner

itdxer commented Aug 19, 2021

Hi @DLPerf,
I've seen this problem and I believe at the time I didn't see a good way to solve it. When I switched neupy from theano to tensorflow I wanted to avoid using context for sessions, but overtime it proved to be a problem. I have some "hacky" fixes in the notebooks somewhere but never got around fixing the main problem. How do you suggest solving the problem?

@itdxer itdxer self-assigned this Aug 19, 2021
@itdxer itdxer added the bug label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants