Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all documented ART1 parameters actually used #287

Open
peterdekker opened this issue Jan 29, 2022 · 0 comments
Open

Not all documented ART1 parameters actually used #287

peterdekker opened this issue Jan 29, 2022 · 0 comments

Comments

@peterdekker
Copy link

Not all parameters that are documented for ART1, are, as far as I can see, actually used: http://neupy.com/modules/generated/neupy.algorithms.ART1.html Three parameters which come from BaseNetwork: show_epoch, shuffle_data and signals, are not used.

If I look at the source code, theseparameters are used in the train() method of BaseNetwork. However, ART1 has its own train() method, which does not call the train() method of BaseNetwork, and does not use these parameters.
Would it be good to remove these parameters from the documentation for ART1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant