Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical Issues #24

Open
7 of 10 tasks
Laoujin opened this issue Mar 28, 2019 · 2 comments
Open
7 of 10 tasks

Technical Issues #24

Laoujin opened this issue Mar 28, 2019 · 2 comments

Comments

@Laoujin
Copy link
Member

Laoujin commented Mar 28, 2019 •
edited
Loading

  • Installation: node-sass issue with Webstorm?
  • Improve readme (only list commands that need to be run to get started)
  • <product ...> zet elk attribuut op aparte lijn voor minder merge conflicts
  • de cart is gedefinieerd als een array van string[] maar is nu het volledige product obj (wijzig naar id?)
  • maak een model voor Product voor type safety
  • Angular.jpg vs angular.jpg filename vs brandname
  • Exercises.md 5E en 5F staan op dezelfde lijn
  • Exercise 5A is pretty much already done in store.ts (in comment)
  • Generate the issues from a json file?
  • run linter on all files
@Laoujin
Copy link
Member Author

Laoujin commented Mar 28, 2019 •
edited
Loading

Also cover:

  • v-for :key moet uniek per pagina
  • !! Mention to git pull on every merge !!
  • Also do a little demo of each merge !!

@Laoujin
Copy link
Member Author

Laoujin commented Mar 28, 2019 •
edited
Loading

Also mention:

  • Start with a Github fork and clone your project, not this one
  • Claim your Issue by replying to it
  • git pull all the time
  • Put the #ID in your PR so it is linked to the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Laoujin