Add fallback on failure obtaining configured implementation.

dkocher · AliveDevil · commit 5abf67e42a14 · 2025-06-26T13:19:53.000+02:00
diff --git a/core/src/main/java/ch/cyberduck/core/random/DefaultSecureRandomProvider.java b/core/src/main/java/ch/cyberduck/core/random/DefaultSecureRandomProvider.java
@@ -53,9 +53,9 @@ public SecureRandom provide() {
                             PreferencesFactory.get().getProperty("connection.ssl.securerandom.provider"));
                 }
                 catch(NoSuchAlgorithmException | NoSuchProviderException e) {
-                    log.warn("Failure {} obtaining secure random", e.getMessage());
+                    log.error("Failure {} obtaining secure random", e.getMessage());
                     // Keep null for default secure random
-                    return null;
+                    seeder = new SecureRandom();
                 }
             }
             return seeder;

Original file line number	Diff line number	Diff line change
`@@ -53,9 +53,9 @@ public SecureRandom provide() {`
`53`	`53`	`PreferencesFactory.get().getProperty("connection.ssl.securerandom.provider"));`
`54`	`54`	`}`
`55`	`55`	`catch(NoSuchAlgorithmException \| NoSuchProviderException e) {`
`56`		`- log.warn("Failure {} obtaining secure random", e.getMessage());`
	`56`	`+ log.error("Failure {} obtaining secure random", e.getMessage());`
`57`	`57`	`// Keep null for default secure random`
`58`		`- return null;`
	`58`	`+ seeder = new SecureRandom();`
`59`	`59`	`}`
`60`	`60`	`}`
`61`	`61`	`return seeder;`